[Kde-pim] [Differential] [Commented On] D927: Implement KDBusService alternative for Windows

[aheinecke (Andre Heinecke)]

aheinecke added a comment.


  Laurent can you give me a review for this please? I've written this class in a way that I think it could be included in a Tier 1 Framework somewhere. (Have not found an appropiate one).
  This is also my first real use of the pimpl idiom. Which i partly decided to use as to better understand it, as this is used all over Kleopatra.
  
  I don't expect you to review the Windows specifics. I tested there and ran the unit test :-)
  
  This is Gpg4all.

INLINE COMMENTS
  kleopatra/utils/kuniqueservice_dbus.cpp:2 Uhm,.. this is not what my patch shows. Tis is a new file and kwatchgnupg/main.cpp was also modified in this patch.

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D927

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aheinecke, mlaurent
Cc: kde-pim, winterz, smartins, vkrause, mlaurent, mbohlender, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/