[Kde-pim] Review Request 126884: Check for and replace strcasestr if neccessary

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126884/
-----------------------------------------------------------

(Updated Feb. 12, 2016, 3:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Volker Krause.


Changes
-------

Submitted with commit cd6220e8c32b75791e27a8323a1552c82767811a by Andre Heinecke to branch master.


Repository: kmime


Description
-------

Neccessary at least for Windows (with mingw-3).
This renames the TimezoneChecks.cmake file to a more generic name so that it can be better extended if more checks are needed.

The replacement function was taken from libreplace as part of QtWebEngine. (I just grepped for strcasecmp in qt)
There is also a replacement in Kdewin but this copies the strings which I found wasteful.
The probably highly optimized version from Kde4 kdelibs/kdecore/fakes.c I've found to complicated ;-)


Diffs
-----

  cmake/CheckTimezone.cmake adc1937 
  cmake/ConfigureChecks.cmake PRE-CREATION 
  src/CMakeLists.txt ef86420 
  src/config-kmime.h.cmake 7b7ef6d 
  src/kmime_util.cpp ed002b9 

Diff: https://git.reviewboard.kde.org/r/126884/diff/


Testing
-------

Compiled under Debian GNU/Linux and for Windows with mingw.


Thanks,

Andre Heinecke

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/