[Kde-pim] Review Request 127117: Reverse the filtering logic

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127117/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 6:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and KDEPIM.


Changes
-------

Submitted with commit bdff68dea3cbe5e59d7c65c7961667ddab0849dc by Martin Klapetek to branch master.


Repository: kpeople


Description
-------

For filtering multiple properties the logic needs to be OR
rather than AND.

For example in Plasma Mobile, one can start a conversation
either with a phonenumber contact or IM contact, so both
properties need to be requested. But with AND matching it
won't return anything (or only those contacts that have both
and user merged them).


Diffs
-----

  autotests/fakecontactsource.cpp b227723 
  autotests/personsproxymodeltest.cpp 1143e5f 
  src/personssortfilterproxymodel.cpp b011cbd 

Diff: https://git.reviewboard.kde.org/r/127117/diff/


Testing
-------

I get both phonenumber and IM contacts in Plasma Mobile


Thanks,

Martin Klapetek

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/