[Kde-pim] Review Request 127099: Fix formatting in Kleopatra selftest details
Andre Heinecke
aheinecke at intevation.de
Wed Feb 17 16:25:29 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127099/
-----------------------------------------------------------
(Updated Feb. 17, 2016, 4:25 p.m.)
Review request for KDEPIM.
Changes
-------
Added screenshots (in german to show that localization still works)
Repository: kdepim
Description
-------
xi18nc escapes richtext in arguments so the messages are not formated. So this patch bypasses xi18nc argument extension by using QString argument extension.
This looks a bit hackish to me and I'm not sure if there is a better solution (without modifying the translated string). Hence the review.
Diffs
-----
kleopatra/selftest/libkleopatrarccheck.cpp dba588b
Diff: https://git.reviewboard.kde.org/r/127099/diff/
Testing
-------
Tested that the message is still translated and shows up correctly. (with formatting now)
File Attachments (updated)
----------------
Before the change (german)
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/620c5411-fe7d-407e-af8a-d3366fd9dfb6__kleo-self-details-old.png
After the change
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/2af916a6-6567-4bb8-b9d8-48243aa9990d__kleo-self-details-new.png
Thanks,
Andre Heinecke
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list