[Kde-pim] [Differential] [Updated] D928: Fix build without qt deprecation compatibility

Tue Feb 9 19:35:51 GMT 2016

aheinecke marked an inline comment as done.

INLINE COMMENTS
  kleopatra/commands/importcertificatescommand.cpp:203 Thanks, you are right I misunderstood the code and thought this would only call Qt::escape if the string is not empty. So I checked that toHtmlEscaped can handle empty values.

  Hurray for obfuscated code. Btw. this was the only place where transform_if is used in Kleopatra. Happy it's gone now ;-)
  kleopatra/utils/auditlog.cpp:40 No but in line 74 there is a use of it. That this worked previously is probably because of an implicit include that's changed by the compatibility setting.
  Without this include it does not compile with an invalid use of incomplete type error.

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D928

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aheinecke, mlaurent
Cc: apol, kde-pim, winterz, smartins, vkrause, mlaurent, mbohlender, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/