[Kde-pim] [Differential] [Commented On] D927: Implement KDBusService alternative for Windows
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Wed Feb 10 15:42:26 GMT 2016
kfunk added a comment.
In https://phabricator.kde.org/D927#18079, @apol wrote:
> > Do you see other Problems?
>
> With the exclusive Kleopatra use-case, my impression is that it would be better to copy over QtSingleApplication rather than coming up with a new implementation that possibly duplicates features and is also possibly buggy. I don't want to see such scary implementations in each and every Qt5-based application that wants to enforce a single instance.
I totally agree. Copying + extending/refactoring QtSingleApplication + putting it in a framework is the way to go here.
It's robust, QtCreator has been using it on all major platforms as 'unique application' solution for ages. I agree the coupling to Q*Application is not perfect, and could be relaxed.
Note this change here only solves the issue on Windows; if we ever want to get Kleopatra in shape for OS X, we'll have to add another few hundred LOCs of platform specific code...
Why not (finally!) fix this in a way all KDE applications can benefit from? :\
> I am not a KDE PIM maintainer, feel free to take my opinion with a grain of salt.
Dito.
REPOSITORY
rKDEPIM KDE PIM
REVISION DETAIL
https://phabricator.kde.org/D927
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: aheinecke, mlaurent
Cc: kfunk, apol, knauss, kde-pim, winterz, smartins, vkrause, mlaurent, mbohlender, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list