[Kde-pim] [Differential] [Commented On] D927: Implement KDBusService alternative for Windows

[mlaurent (Laurent Montel)]

mlaurent added inline comments.

INLINE COMMENTS
  kleopatra/autotests/kuniqueservicetest.cpp:46 m_proc(Q_NULLPTR)
  kleopatra/autotests/kuniqueservicetest.cpp:122 QStringLiteral("...");
  kleopatra/autotests/kuniqueservicetest.cpp:124 Same here use QStringLiteral when possibke
  kleopatra/utils/kuniqueservice_win.cpp:54 const QString get...() const ?
  kleopatra/utils/kuniqueservice_win.cpp:219 Try to compile from scratch and see if you have an moc warning about it.
  If you have it's that you don't need it.
  And indeed for me it's not necessary as you don't have slots/signal in .Cpp file

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D927

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aheinecke, mlaurent
Cc: knauss, kde-pim, winterz, smartins, vkrause, mlaurent, mbohlender, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/