[Kde-pim] Review Request 127099: Fix formatting in Kleopatra selftest details
Laurent Montel
montel at kde.org
Wed Feb 17 16:19:50 GMT 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127099/#review92502
-----------------------------------------------------------
Screenshot is welcome.
But indeed if you don't want to change i18n it will be difficult to make it better as this hack
- Laurent Montel
On fév. 17, 2016, 2:03 après-midi, Andre Heinecke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127099/
> -----------------------------------------------------------
>
> (Updated fév. 17, 2016, 2:03 après-midi)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> xi18nc escapes richtext in arguments so the messages are not formated. So this patch bypasses xi18nc argument extension by using QString argument extension.
>
> This looks a bit hackish to me and I'm not sure if there is a better solution (without modifying the translated string). Hence the review.
>
>
> Diffs
> -----
>
> kleopatra/selftest/libkleopatrarccheck.cpp dba588b
>
> Diff: https://git.reviewboard.kde.org/r/127099/diff/
>
>
> Testing
> -------
>
> Tested that the message is still translated and shows up correctly. (with formatting now)
>
>
> Thanks,
>
> Andre Heinecke
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list