[Kde-pim] Review Request 127028: Inform user when searched collections are not fully indexed

[Daniel Vrátil]

> On Feb. 10, 2016, 3:16 p.m., Sandro Knauß wrote:
> > kmail/searchdialog/searchwindow.h, line 161
> > <https://git.reviewboard.kde.org/r/127028/diff/2/?file=443905#file443905line161>
> >
> >     a List called mCollectionId? this should be renamed to mCollections or QList<Akonadi:Id> mCollectionIds

I prefer not to touch unrelated code in this patches.


> On Feb. 10, 2016, 3:16 p.m., Sandro Knauß wrote:
> > kmail/searchdialog/searchwindow.cpp, line 889
> > <https://git.reviewboard.kde.org/r/127028/diff/2/?file=443906#file443906line889>
> >
> >     Why not QVector<Akonadi::Id> ?

There's only Akonadi::Entity::Id (or Akonadi::Collection::Id and Akonadi::Item::Id). I don't use them much, because the name is very long :)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127028/#review92221
-----------------------------------------------------------


On Feb. 10, 2016, 2 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127028/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 2 p.m.)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When creating a new search we now check if all collections we search in are fully indexed. This is done by comparing CollectionStatistics from Akonadi with number of indexed items in each collection reported by the Indexer. If some collections are not fully indexed, we show a dialog with a list of those collections, allowing users to force-index those collections.
> 
> Secondly, when opening a search collection we check if all collections the search is performed in are fully indexed and if not, we show a message widget with explanation.
> 
> See the attached screenshots.
> 
> This is only the UI part, I still have to implement the actual reindexing in the indexing agent, so the "Reindex" button does not do anything yet.
> 
> To test, remove the Baloo Indexing Agent, open ~/.kde/share/config/baloorc and set "lastItem" to (distant) future. Then send yourself an email and when it arrives, add Baloo Indexing Agent again. It won't pick up the email, because it will only check for new emails since the timestamp in ballorc, which we moved to future. Now you should be getting the warnings about unindexed collection, when you try to search it.
> 
> 
> Diffs
> -----
> 
>   kmail/CMakeLists.txt 621180c 
>   kmail/collectionpage/collectionmaintenancepage.cpp 8c4dad5 
>   kmail/searchdialog/incompleteindexdialog.h PRE-CREATION 
>   kmail/searchdialog/incompleteindexdialog.cpp PRE-CREATION 
>   kmail/searchdialog/searchwindow.h 8cecfd6 
>   kmail/searchdialog/searchwindow.cpp 3853fe2 
>   kmail/ui/incompleteindexdialog.ui PRE-CREATION 
>   messagelist/CMakeLists.txt d2ebf80 
>   messagelist/core/widgetbase.cpp 83674e3 
>   messagelist/core/widgets/searchcollectionindexingwarning.h PRE-CREATION 
>   messagelist/core/widgets/searchcollectionindexingwarning.cpp PRE-CREATION 
>   pimcommon/CMakeLists.txt 9d69009 
>   pimcommon/util/indexerutils.h PRE-CREATION 
>   pimcommon/util/indexerutils.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127028/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Search dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/10/46e22e95-a5d9-4606-ad96-9790fd2bf6e7__kmail-search-dialog.png
> Search folder notification
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/10/d2c183c5-9ca8-4419-be4b-3a2bb21ca1e1__kmail-search1.png
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/