[Kde-pim] Review Request 126971: Add "Copy Decrypted Message To..." action to message list

[Andre Heinecke]

> On Feb. 2, 2016, 4:46 p.m., Andre Heinecke wrote:
> > Tried it out and works as expected. Yes thinking back the signature breakage was also something that happened with the e35 patch as far as I remember.
> 
> Daniel Vrátil wrote:
>     I now realized the "Copy decrypted" action is still missing in the context menu when you drag&drop a message into a folder. Do you want me to add it there too, or is the message list context menu enough? Might be bit more tricky to add it to the d&d menu as it's managed by code in kdepimlibs rather than kmail IIRC.

Leave it out for now. We did not have that in e35 either.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126971/#review91974
-----------------------------------------------------------


On Feb. 2, 2016, 4:32 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126971/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 4:32 p.m.)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This adds a new action to message context menu that allows to create a decrypted copy of an existing email. Based on the e3 patches from aheinecke.
> 
> 
> Diffs
> -----
> 
>   kmail/kmail_part.rc db3c27b 
>   kmail/kmcommands.h 1208da1 
>   kmail/kmcommands.cpp f7f06e92 
>   kmail/kmmainwidget.h 68f57a1 
>   kmail/kmmainwidget.cpp 02bedaa 
>   kmail/kmmainwin.rc db3c27b 
> 
> Diff: https://git.reviewboard.kde.org/r/126971/diff/
> 
> 
> Testing
> -------
> 
> Tested with S/MIME and PGP encrypted emails. Inner signatures are preserved. The only issue I noticed is that encrypted emails with outter signature are marked as "bad", which is to be expected. The e3 patches mention something about stripping outter signatures, but I could not really test what the original code was doing :)
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/