Review Request 128724: Allways save the upper case version of a custom key of a KContacts::Addressee

[Bernhard Scheirle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128724/
-----------------------------------------------------------

Review request for KDEPIM and Laurent Montel.


Bugs: 317966
    https://bugs.kde.org/show_bug.cgi?id=317966


Repository: kcontacts


Description
-------

Allways save the upper case version of a custom key. This forces developers to not use case-sensitive keys.
Case-sensitive keys are bad, because:
1. RFC 6350 explicitly says that keys are case-insensitive: https://tools.ietf.org/html/rfc6350#section-3.3
2. Ex- and importing contacts may change the case (e.g. if you use owncloud).

Please also see the two other related review requests: 
* https://git.reviewboard.kde.org/r/128723
* https://git.reviewboard.kde.org/r/128722

Since I'm fairly new to KDE development I appreciate any feedback.


Diffs
-----

  src/addressee.cpp 86072c0da026e85fe5cd2a2115a2c47e0f31be74 

Diff: https://git.reviewboard.kde.org/r/128724/diff/


Testing
-------

ctest fails currently (4 test cases fail).
I want to wait for your feedback before updating the test cases.


Thanks,

Bernhard Scheirle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160820/5053260d/attachment.html>