Review Request 128724: [WIP] [KContacts] Allways save the upper case version of a custom key of a KContacts::Addressee

[Bernhard Scheirle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128724/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 12:57 a.m.)


Review request for KDEPIM and Laurent Montel.


Changes
-------

* Fixed autotests
* Fixed vcardtool
* Removed patch files


Bugs: 317966
    https://bugs.kde.org/show_bug.cgi?id=317966


Repository: kcontacts


Description
-------

Allways save the upper case version of a custom key. This forces developers to not use case-sensitive keys.
Case-sensitive keys are bad, because:
1. RFC 6350 explicitly says that keys are case-insensitive: https://tools.ietf.org/html/rfc6350#section-3.3
2. Ex- and importing contacts may change the case (e.g. if you use owncloud).

Of cause this change affects a few other applications:

* https://git.reviewboard.kde.org/r/128723
    * akonadi-contacts/src/editor/generalinfoeditor/messaging/messagingwidgetlister.cpp
    * akonadi-contacts/src/standardcontactformatter.cpp
    * akonadi-contacts/src/editor/customfieldeditor/customfieldslistwidget.cpp


* https://git.reviewboard.kde.org/r/128722
    * kdepim-apps-libs/kaddressbookgrantlee/src/printing/contactgrantleeprintobject.cpp
    * kdepim-apps-libs/kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp


* (No review request yet)
    * kdepim/kmail/src/kmreaderwin.cpp


* (No review request yet)
    * kopete/libkopete/kabcpersistence.cpp


* (No review request yet)
    * akonadi-google-applets/contacts/src/contactwidgetitem.cpp


* (No review request yet)
    * libkgapi/src/contacts/contactsservice.cpp


* (No review request yet)
    * messagelib/messageviewer/src/header/contactdisplaymessagememento.cpp


Since I'm fairly new to KDE development I appreciate any feedback.


Diffs (updated)
-----

  autotests/addresseetest.cpp 156d6425874f2d9b155eeb2e4d96cf8be6bc4ae6 
  autotests/customidentifiertest.cpp f96defd7ed8b71852d5e160533112c2a95710acf 
  autotests/data/vcard5.vcf.ref 531271f4c70451686a588d417181d3990cdf029d 
  src/addressee.h 4dc0dfd11ff6e96dc3fc796ce7e3add628dd44a6 
  src/addressee.cpp 86072c0da026e85fe5cd2a2115a2c47e0f31be74 
  src/vcardtool.cpp e3684ba6e32584a65e9bec09f00b828b59be45a4 

Diff: https://git.reviewboard.kde.org/r/128724/diff/


Testing (updated)
-------

ctest passes except: addresstest
But the error does not look like it's the result of my changes.

FAIL!  : AddressTest::formatTest() Compared values are not the same
   Actual   (address.formattedAddress(QStringLiteral("Jim Knopf"))): "Jim Knopf\nLummerlandstr. 1\n12345 Lummerstadt"
   Expected (result)                                               : "Jim Knopf\nLummerlandstr. 1\nLummerstadt, 12345"
   Loc: [/mnt/sdc/bernhardscheirle/src/kde/kcontacts/autotests/addresstest.cpp(233)]


Thanks,

Bernhard Scheirle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160823/5856345d/attachment.html>