Review Request 128781: [Akregator] Prevent feed split in notification
Laurent Montel
montel at kde.org
Mon Aug 29 06:19:59 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128781/#review98761
-----------------------------------------------------------
Ship it!
We can add this patch in master and revert if there is a problem in the future.
I will add it in master.
Thanks
- Laurent Montel
On Aug. 27, 2016, 2:11 p.m., Giuseppe Calà wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128781/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2016, 2:11 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Actually a doNotify() is fired when new articles list is >= 20 (perhaps to reduce notification cluttering?) and, with a lot of news, feeds are splitted in notification pop-up [1].
> After last notification patches that reduce spam and compacts articles I think that this behaviour can be removed: [2]
>
>
> P.S. I have not rights to commit
>
>
> Diffs
> -----
>
> akregator/src/notificationmanager.cpp 1ffd11b
>
> Diff: https://git.reviewboard.kde.org/r/128781/diff/
>
>
> Testing
> -------
>
> [1] http://i.imgur.com/Vv3qPRP.png
> [2] http://i.imgur.com/nEaxqNp.png
>
>
> Thanks,
>
> Giuseppe Calà
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160829/a6a6a9de/attachment.html>
More information about the kde-pim
mailing list