[Differential] [Requested Changes To] D2434: Cache tags by name instead of gid

[dvratil (Daniel Vrátil)]

dvratil requested changes to this revision.
dvratil added a reviewer: dvratil.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, two minor nitpicks:
  
  As this introduces new public API, you have to bump PIM_VERSION in CMakeLists.txt.

INLINE COMMENTS

> tagcache.h:45
>      Akonadi::Tag getTagByGid(const QByteArray &gid) const;
> +    Akonadi::Tag getTagByName(const QString &gid) const;
>  

The argument should be called `name`

REPOSITORY
  rCALENDARSUPPORT PIM: Calendar Support

REVISION DETAIL
  https://phabricator.kde.org/D2434

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dkurz, #kde_pim, dvratil
Cc: dvratil, tillschafer, knauss, kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160823/f43b204a/attachment.html>