Review Request 128735: [Akregator] Limit articles in notification pop-up

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128735/#review98556
-----------------------------------------------------------



+1

I'll fix the notification popup, yet still notifications shouldn't become novels in the first place.

What's up with the massive spacing between entries, though?

- Kai Uwe Broulik


On Aug. 22, 2016, 2:54 nachm., Giuseppe Calà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128735/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 2:54 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Akregator's notification manager is coded to show all new articles from all feeds in notification pop-up and when there are a lot of them the pop-up can go beyond desktop height [1].
> 
> This patch limits the number of entries to 2 articles for feed, plus a line with the remaining number of new articles [2].
> 
> 
> Diffs
> -----
> 
>   akregator/src/notificationmanager.cpp 9730983 
> 
> Diff: https://git.reviewboard.kde.org/r/128735/diff/
> 
> 
> Testing
> -------
> 
> [1] before: http://i.imgur.com/exVQSdi.png
> [2] after : http://i.imgur.com/WqUmoj9.png
> 
> 
> Thanks,
> 
> Giuseppe Calà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160822/7344ee28/attachment.html>