[Kde-pim] Review Request 128605: [kmail] Fix jump lists by renaming org.kde.{kmail => kmail2}.desktop

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128605/#review98125
-----------------------------------------------------------



For sure it will not commit in 16.08 it's too late.
We use some code which requires org.kde.kmail so it will break it.
So it will evaluate for 16.12 not 16.08.

Regards

- Laurent Montel


On Aug. 4, 2016, 9:29 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128605/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:29 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Currently broken because WM_CLASS is set to 'kmail2' which does not correspond with desktop file.
> 
> some IRC log:
> 
> Sho_: let me give you some context
> Sho_: Plasma's Task Manager contains a complicated heuristic that tries to find out what app a window belongs to, working off of window and process metadata
> Sho_: it's necessary to e.g. pin an app as a launcher based on a window, or to group windows belonging to the same app, or fetch jump list actions from the .desktop file
> Sho_: because kmail sets bad metadata, the heuristic works only as far as being able to find the executable - that's enough to store a launcher, which then points at the executable and uses a base64 serialization of the window icon as icon for it
> Sho_: but since it can't find the .desktop file, it can't e.g. show jump lists (or grab the right icon from the icon theme based on icon name)
> 
> 
> Diffs
> -----
> 
>   kmail/src/CMakeLists.txt 3df422d731393263f00ff26c35e62e47ec851d6f 
>   kmail/src/data/org.kde.kmail.appdata.xml  
>   kmail/src/data/org.kde.kmail.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/128605/diff/
> 
> 
> Testing
> -------
> 
> builds and runs, now also has jump lists (if kmail is started standalone)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/