[Differential] [Request, 43 lines] D2423: Set initial categories for non-cached incidences

[dkurz (Denis Kurz)]

dkurz created this revision.
dkurz added a reviewer: KDE PIM.
dkurz set the repository for this revision to rINCIDENCEEDITOR PIM: Incidence Editor.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.

REVISION SUMMARY
  The old implementation tried to match loaded and existing tags on the
  akonadi server side. A new CreateTag job was sent to the server, with
  the name of the new tag and the hint to first check if this tag already
  exists. The server, however, does not know about any tag names, and
  tried to match the new tag by global id, which is completely random in
  the TagCreate job.
  
  Now, the matching is done on the client side, where the concept of tag
  names is located. We fetch all tags from the server and check if the
  categories of the loaded category match the names of these tags. For
  every category that was not found in the tag list returned from the
  server, we send a TagCreate job.
  
  Fixes Bug 352645

TEST PLAN
  Opening the incidenceeditor from korganizer's eventviews for variuos
  cached and non-cached items did not produce a single tag duplicate.
  Also, the TagWidget's content is set correctly after the incidenceeditor
  is created. Without the patch, everything reported in Bug 352645
  happened here, too.
  
  Patch quality: works for me.

REPOSITORY
  rINCIDENCEEDITOR PIM: Incidence Editor

REVISION DETAIL
  https://phabricator.kde.org/D2423

AFFECTED FILES
  src/incidencecategories.cpp
  src/incidencecategories.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dkurz, #kde_pim
Cc: kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160812/a0f395ed/attachment.html>