Review Request 128724: [WIP] [KContacts] Allways save the upper case version of a custom key of a KContacts::Addressee

[Bernhard Scheirle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128724/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 12:44 a.m.)


Review request for KDEPIM and Laurent Montel.


Changes
-------

Trying to update the diff, not sure if I'm doing the right thing :)


Bugs: 317966
    https://bugs.kde.org/show_bug.cgi?id=317966


Repository: kcontacts


Description
-------

Allways save the upper case version of a custom key. This forces developers to not use case-sensitive keys.
Case-sensitive keys are bad, because:
1. RFC 6350 explicitly says that keys are case-insensitive: https://tools.ietf.org/html/rfc6350#section-3.3
2. Ex- and importing contacts may change the case (e.g. if you use owncloud).

Of cause this change affects a few other applications:

* https://git.reviewboard.kde.org/r/128723
    * akonadi-contacts/src/editor/generalinfoeditor/messaging/messagingwidgetlister.cpp
    * akonadi-contacts/src/standardcontactformatter.cpp
    * akonadi-contacts/src/editor/customfieldeditor/customfieldslistwidget.cpp


* https://git.reviewboard.kde.org/r/128722
    * kdepim-apps-libs/kaddressbookgrantlee/src/printing/contactgrantleeprintobject.cpp
    * kdepim-apps-libs/kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp


* (No review request yet)
    * kdepim/kmail/src/kmreaderwin.cpp


* (No review request yet)
    * kopete/libkopete/kabcpersistence.cpp


* (No review request yet)
    * akonadi-google-applets/contacts/src/contactwidgetitem.cpp


* (No review request yet)
    * libkgapi/src/contacts/contactsservice.cpp


* (No review request yet)
    * messagelib/messageviewer/src/header/contactdisplaymessagememento.cpp


Since I'm fairly new to KDE development I appreciate any feedback.


Diffs
-----

  src/addressee.cpp 86072c0da026e85fe5cd2a2115a2c47e0f31be74 

Diff: https://git.reviewboard.kde.org/r/128724/diff/


Testing
-------

ctest fails currently (4 test cases fail).
I want to wait for your feedback before updating the test cases.


File Attachments (updated)
----------------

0002-Transform-custom-keys-always-to-uppercase.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/23/be80450e-7174-40b1-aa5e-2058ed95e585__0002-Transform-custom-keys-always-to-uppercase.patch
0001-Fix-Addressee-customs-documentation-The-return-value.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/23/a25d46a3-43f1-4045-aaa3-514827f084fc__0001-Fix-Addressee-customs-documentation-The-return-value.patch
0003-Use-uppercase-for-some-strings-to-match-the-return-f.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/23/2a5aed96-7519-4260-a359-115962237796__0003-Use-uppercase-for-some-strings-to-match-the-return-f.patch
0004-Update-autotests-to-match-the-new-format-of-Addresse.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/23/9a252203-b893-4f89-813e-9fa02c967418__0004-Update-autotests-to-match-the-new-format-of-Addresse.patch


Thanks,

Bernhard Scheirle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160823/5ff6bd92/attachment.html>