[Kde-pim] [Differential] [Request, 11 lines] D1513: Fix displaying ITIP invitations

[dvratil (Daniel Vrátil)]

dvratil created this revision.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.

REVISION SUMMARY
  Probably some OTP refactoring broke displaying of ITIP invitation.
  This patch fixes the problem. It may not fix the root cause of the problem,
  but at least it makes ITIP invitations work again.
  
  What happens is that OTP::parseObjectTreeInternal() first calls
  Formatter::format() without the asyncResultObserver. Without this patch
  it still creates the new memento, but does not connect it to the observer.
  Then OTP calls the Formatter again immediatelly after, but this time with
  a valid asyncResultObserver. Because the memento already exists, this only
  triggers the codepath that checks whether the memento is finished (which
  it is not) and exists. When the memento is finished nothing happens, because
  it wasn't initially connected to the observer to force update of the Viewer.
  
  With this patch we don't create the memento if there is no asyncResultObserver.
  That means that the next time the Formatter is called with a valid
  asyncResultObserver we create the memento and connect it to the observer.
  Once the memento is finished, the Viewer is updated and the invitation
  is displayed correctly.

REPOSITORY
  rKDEPIM KDE PIM

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1513

AFFECTED FILES
  plugins/messageviewer/bodypartformatter/calendar/text_calendar.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, mbohlender, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/