[Kde-pim] Review Request 127775: Cache idsToSave
Albert Astals Cid
aacid at kde.org
Wed Apr 27 23:20:50 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127775/
-----------------------------------------------------------
Review request for KDEPIM and Laurent Montel.
Bugs: 361737
http://bugs.kde.org/show_bug.cgi?id=361737
Repository: kdepim-runtime
Description
-------
Seems doing all the work each time shouldDeleteId is called is not as fast as i thught, so cache it until the next list job finishes (i.e. we're checking email again).
The diff looks big but it's actually not that big, it's just that i indented the code. https://paste.kde.org/pmfkv64gc has a version without the intentation taken into account.
Diffs
-----
resources/pop3/pop3resource.h 659ed6b
resources/pop3/pop3resource.cpp 3070e5f
Diff: https://git.reviewboard.kde.org/r/127775/diff/
Testing
-------
None, it compiles and should work, but i have not tested it.
Thanks,
Albert Astals Cid
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list