[Kde-pim] Review Request 125368: Fix heap-use-after-free in the imap resource

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125368/
-----------------------------------------------------------

(Updated Sept. 24, 2015, 10:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Laurent Montel.


Changes
-------

Submitted with commit be88f08f630d24863b6e998756f3947429125b05 by Albert Astals Cid to branch Applications/15.08.


Repository: kdepim-runtime


Description
-------

Keep the collection() around more time, otherwise we're accessing already deleted data.

See
https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2015.08/job/kdepim-runtime%20Applications-15.08%20stable-kf5-qt5/21/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/testmoveitemstask/
https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2015.08/job/kdepim-runtime%20Applications-15.08%20stable-kf5-qt5/21/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/testchangecollectiontask/
https://build.kde.org/user/aacid/my-views/view/KDE%20Applications%2015.08/job/kdepim-runtime%20Applications-15.08%20stable-kf5-qt5/21/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/testadditemtask/


Diffs
-----

  resources/imap/additemtask.cpp e2bd6fd 
  resources/imap/changecollectiontask.cpp 3e31106 
  resources/imap/moveitemstask.cpp a6329db 

Diff: https://git.reviewboard.kde.org/r/125368/diff/


Testing
-------

Valgrind is happy, tests pass.


Thanks,

Albert Astals Cid

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/