[Kde-pim] Review Request 125426: Check response content size for search job in kimap

Xuetian Weng wengxt at gmail.com
Sun Sep 27 20:21:06 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125426/
-----------------------------------------------------------

(Updated Sept. 27, 2015, 7:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for Akonadi and Laurent Montel.


Changes
-------

Submitted with commit 8391392149ecae53fa4b792d9e7f06b1a23a8f9f by Weng Xuetian to branch master.


Bugs: 351850
    https://bugs.kde.org/show_bug.cgi?id=351850


Repository: kimap


Description
-------

Bug shows that toString is being called against a null pointer, which possible because of response.content does not have enough element inside it. I also occasionally hit this on kimap 15.08.1.

I checked some other jobs in the same folder. It seems that other jobs do check the response.content.size() before look into it, so this may help fix the issue.


Diffs
-----

  src/searchjob.cpp 93cbfb2 

Diff: https://git.reviewboard.kde.org/r/125426/diff/


Testing
-------

Compiles.


Thanks,

Xuetian Weng

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list