[Kde-pim] Review Request 125331: Port part of KCalUtils::IncidenceFormatter to Grantlee template system

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125331/#review85709
-----------------------------------------------------------



src/grantlee_plugin/icon.h (line 56)
<https://git.reviewboard.kde.org/r/125331/#comment59229>

    explicit ?



src/grantlee_plugin/icon.h (line 66)
<https://git.reviewboard.kde.org/r/125331/#comment59230>

    explicit ?



src/grantlee_plugin/icon.cpp (line 57)
<https://git.reviewboard.kde.org/r/125331/#comment59231>

    const int partsSize = parts.size();
    => minor optimization :)



src/grantlee_plugin/kcalendargrantleeplugin.h (line 33)
<https://git.reviewboard.kde.org/r/125331/#comment59232>

    explicit



src/grantleeki18nlocalizer.cpp (line 76)
<https://git.reviewboard.kde.org/r/125331/#comment59227>

    {...} is C++11 ?



src/grantleetemplatemanager.cpp (line 36)
<https://git.reviewboard.kde.org/r/125331/#comment59228>

    Missing delete engine in destructor ?


- Laurent Montel


On sep. 20, 2015, 9:48 après-midi, Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125331/
> -----------------------------------------------------------
> 
> (Updated sep. 20, 2015, 9:48 après-midi)
> 
> 
> Review request for KDEPIM, Laurent Montel and Volker Krause.
> 
> 
> Repository: kcalutils
> 
> 
> Description
> -------
> 
> I needed to extend the HTML generated for todos so that it includes some more fields useful for the Phabricator resource. After digging around the code a bit a decided to see if I can port it to Grantlee, which is way easier to maintain and modify and also provides much cleaner separation between logic and representation and this is the result of it :)
> 
> This patch does not port the entire IndicendeFormatter to Grantlee, only events, tasks, journals and free/busy, I haven't touched the ITIP formatter yet.
> 
> The new code works just fine, but I consider it more of a proof-of-concept than a ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, should we use the custom Grantlee plugin, ...?
> 
> Also please see the mail on kde-pim regarding where should we put the plugin :)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d145b6a 
>   src/CMakeLists.txt 0d7bdcc 
>   src/grantlee_plugin/CMakeLists.txt PRE-CREATION 
>   src/grantlee_plugin/icon.h PRE-CREATION 
>   src/grantlee_plugin/icon.cpp PRE-CREATION 
>   src/grantlee_plugin/kcalendargrantleeplugin.h PRE-CREATION 
>   src/grantlee_plugin/kcalendargrantleeplugin.cpp PRE-CREATION 
>   src/grantleeki18nlocalizer.cpp PRE-CREATION 
>   src/grantleeki18nlocalizer_p.h PRE-CREATION 
>   src/grantleetemplatemanager.cpp PRE-CREATION 
>   src/grantleetemplatemanager_p.h PRE-CREATION 
>   src/incidenceformatter.cpp 36b9fe5 
>   templates/CMakeLists.txt PRE-CREATION 
>   templates/attendee_row.html PRE-CREATION 
>   templates/event.html PRE-CREATION 
>   templates/freebusy.html PRE-CREATION 
>   templates/incidence_header.html PRE-CREATION 
>   templates/journal.html PRE-CREATION 
>   templates/template_base.html PRE-CREATION 
>   templates/todo.html PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125331/diff/
> 
> 
> Testing
> -------
> 
> I can see my events.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/