[Kde-pim] Review Request 125032: Port KAlarm from KSpeech to QTextToSpeech

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125032/#review84802
-----------------------------------------------------------



kalarm/commandoptions.cpp (line 376)
<https://git.reviewboard.kde.org/r/125032/#comment58690>

    Looking at the code for TextToSpeech::self()->isReady(), there are two possible reasons for it to return false - either it's not compiled with QTextToSpeech support, or the text-to-speech backend has failed. The TextToSpeech class needs an additional method to determine which reason it is not available. As it stands, this error message is inadequate.


- David Jarvie


On Sept. 3, 2015, 9:12 a.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125032/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 9:12 a.m.)
> 
> 
> Review request for KDEPIM and David Jarvie.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> KSpeech is going to die in 15.08, we let's use QTextToSpeech (or even better, let's use Laurent's abstract TTS framework from pimcommon).
> 
> 
> Diffs
> -----
> 
>   kalarm/commandoptions.cpp 928f9ee 
>   kalarm/kalarmapp.h 70a1e8f 
>   kalarm/kalarmapp.cpp 91aec82 
>   kalarm/messagewin.cpp 0b628a3 
>   kalarm/prefdlg.cpp 3ee4ad3 
>   kalarm/soundpicker.cpp 363cf18 
> 
> Diff: https://git.reviewboard.kde.org/r/125032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/