[Kde-pim] Review Request 125364: Fix heap-use-after-free in ICalFormatImpl::readICalDateTime

Albert Astals Cid aacid at kde.org
Wed Sep 23 17:57:13 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125364/
-----------------------------------------------------------

Review request for KDEPIM-Libraries and Laurent Montel.


Repository: kcalcore


Description
-------

tzid = parts.first().toAscii(); was assigning the temporary const char * to tzid that was invalid on the next line, so instead of keeping a const char * keep a QByteArray


Diffs
-----

  src/icalformat_p.cpp 6db5714 

Diff: https://git.reviewboard.kde.org/r/125364/diff/


Testing
-------

valgrind doesn't complain anymore


Thanks,

Albert Astals Cid

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list