[Kde-pim] Review Request 125609: Don't crash showing context menu for attachments with unknown mimetypes

[Sandro Knauß]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125609/#review86733
-----------------------------------------------------------

Ship it!


Ship It!

- Sandro Knauß


On Okt. 12, 2015, 4:20 nachm., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125609/
> -----------------------------------------------------------
> 
> (Updated Okt. 12, 2015, 4:20 nachm.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> KMimeType::mimeType() can return 0 so this code could crash.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/attachment/attachmentcontrollerbase.cpp 2e45d19 
> 
> Diff: https://git.reviewboard.kde.org/r/125609/diff/
> 
> 
> Testing
> -------
> 
> was crashing on an attachment with type application/x-pkcs7-signature. for some reason KMimeType::mimeType() is returning 0 for that. the apidoc says KMimeType::mimeType() can return 0 so this is the right thing to do in any event.
> 
> doesn't crash now.
> 
> Probably needs to be merged to modern KDEPIM.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/