[Kde-pim] Review Request 125713: [libkleo] Fix CMakeLists.txt, KF5PimTextEdit headers

[Laurent Montel]

> On oct. 20, 2015, 7:22 matin, Laurent Montel wrote:
> > it's not correct if you add KF5::PimTextEdit
> 
> Andreas Sturmlechner wrote:
>     It is entirely possible that I'm wrong, but it is used in code and links with it. I had to add it to fix build.
>     
>     libkleo/src/CMakeLists.txt has: set (kleo_LIB_LIBS PUBLIC KF5::QGpgme PRIVATE KF5::PimCommon KF5::ConfigCore KF5::CoreAddons KF5::PimTextEdit)

yep you need to add KF5::PimTextEdit but not changing headers.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125713/#review87114
-----------------------------------------------------------


On oct. 20, 2015, 12:23 matin, Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125713/
> -----------------------------------------------------------
> 
> (Updated oct. 20, 2015, 12:23 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> - Add missing search for KF5PimTextEdit
> - Fix headers in src/ui/auditlogviewer.cpp, src/ui/auditlogviewer.h
> 
> 
> Diffs
> -----
> 
>   libkleo/CMakeLists.txt d3d6032d7de442bbbc21bfb3b40943ca16417413 
>   libkleo/src/ui/auditlogviewer.h f866fecaa80411a895d4cc228fee43acec97ade4 
>   libkleo/src/ui/auditlogviewer.cpp 8d5d722b9496dbfdfc43e4156b67c85fd28e6394 
> 
> Diff: https://git.reviewboard.kde.org/r/125713/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/