[Kde-pim] Review Request 125477: Fix wrong connect

Laurent Montel montel at kde.org
Fri Oct 2 13:47:42 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125477/#review86223
-----------------------------------------------------------

Ship it!


Seems logical.
Ship it.

- Laurent Montel


On oct. 1, 2015, 9:56 après-midi, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125477/
> -----------------------------------------------------------
> 
> (Updated oct. 1, 2015, 9:56 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I guess at some point this was wrongly ported, the slot object has to be parent(), that is a RecipientsEditor, not parent, which is the widget the new line is immediately created on.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/recipient/recipientseditor.cpp 9f31da7 
> 
> Diff: https://git.reviewboard.kde.org/r/125477/diff/
> 
> 
> Testing
> -------
> 
> QObject::connect: Cannot connect MessageComposer::RecipientLineNG::addRecipient(RecipientLineNG*,QString) to (null)::addRecipient(RecipientLineNG*,QString) is gone when starting to write a new email
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list