[Kde-pim] Review Request 125746: Make akonadi_control a qguiapplication for session management

[Daniel Vrátil]

> On Oct. 22, 2015, 12:35 p.m., Daniel Vrátil wrote:
> > src/akonadicontrol/main.cpp, line 53
> > <https://git.reviewboard.kde.org/r/125746/diff/1/?file=412164#file412164line53>
> >
> >     Please add the AkGuiApplication typedef to src/shared/akapplication.h and use it here.
> 
> Xuetian Weng wrote:
>     AkGuiApplication is already occupied by  AkApplicationImpl<QApplication>, any other naming advice?
> 
> Xuetian Weng wrote:
>     ping :)

I think the sensible thing to do is to name the Ak*Application typedefs to match the Q*Applications they wrap, so AkApplication -> QApplication, AkGuiApplication -> QGuiApplication. QApplication is only used by Agent Server, so the change should be trivial.

I say ship this one as it is now, and feel free to adjust the names in a separate commit (or I can do that if you want).


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125746/#review87234
-----------------------------------------------------------


On Oct. 21, 2015, 11:47 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125746/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 11:47 p.m.)
> 
> 
> Review request for Akonadi and Daniel Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> As suggested on the mailing list, make akonadi_control a QGuiApplication to make it exit with session.
> 
> AkGuiApplication is not used here, because AkApplicationImpl<QApplication> which will pull in unnecessary Qt5::Widgets dependency.
> 
> Also disable session auto restart since akonadi_control is started on demand.
> 
> 
> Diffs
> -----
> 
>   src/akonadicontrol/CMakeLists.txt fb3deee 
>   src/akonadicontrol/main.cpp 209640b 
> 
> Diff: https://git.reviewboard.kde.org/r/125746/diff/
> 
> 
> Testing
> -------
> 
> No more remaining akonadi process after logout.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/