[Kde-pim] Review Request 125461: do not allow isValid to create the maildirs

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125461/#review86545
-----------------------------------------------------------

Ship it!


+2

- Daniel Vrátil


On Sept. 30, 2015, 11:35 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125461/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 11:35 a.m.)
> 
> 
> Review request for KDEPIM and Daniel Vrátil.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> using isValid with auto-creation means that it will be able to create
> directories when a test is run as root and therefore fail assertations
> 
> 
> Diffs
> -----
> 
>   resources/maildir/libmaildir/autotests/testmaildir.cpp 180a925c5c0426df41ca19a8c85191acced1a43b 
> 
> Diff: https://git.reviewboard.kde.org/r/125461/diff/
> 
> 
> Testing
> -------
> 
> complete test run in a container as root
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/