[Kde-pim] Review Request 125748: KManageSieve::Session: move network communication to separate thread

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125748/#review87269
-----------------------------------------------------------



libksieve/src/kmanagesieve/sessionthread.cpp (line 10)
<https://git.reviewboard.kde.org/r/125748/#comment59945>

    session.cpp (where some of this code comes from) is LGPLv2+, shouldn't this match that?


- Volker Krause


On Oct. 21, 2015, 11:43 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125748/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 11:43 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This moves all code in KManageSieve::Session that deals with KTcpSocket and SASL to a separate thread. The reason for this is that when I'm on  a very bad/slow internet connection, the initial SASL handshake blocks in sasl_client_new(), apparently due to synchronous DNS resolution. Handling the communication in the main thread then freezes KMail on start as the Sieve code tries to check for the Vacation script. Moving the SASL communication to a thread solves the problem.
> 
> 
> Diffs
> -----
> 
>   libksieve/src/kmanagesieve/CMakeLists.txt 6199e73 
>   libksieve/src/kmanagesieve/session.h ec3cc87 
>   libksieve/src/kmanagesieve/session.cpp aa24f93 
>   libksieve/src/kmanagesieve/sessionthread.cpp PRE-CREATION 
>   libksieve/src/kmanagesieve/sessionthread_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125748/diff/
> 
> 
> Testing
> -------
> 
> I can still access my Sieve server from KMail and KMail no longer freezes after start.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/