[Kde-pim] Review Request 122940: Patch to fix build on OSX 10.9

[Marko Käning]

> On March 15, 2015, 3:38 p.m., Allen Winter wrote:
> > Renee, how about matching the implementation signature in blogger.cpp, i.e. use the typedef in blogger.cpp as well.  else it will probably confuse doxygen or someone else later on who will decide to matchup the signatures.
> 
> Marko Käning wrote:
>     Sound't like a good plan.
>     
>     Talking about later... Where is this code in KF5 by now, Allen?
> 
> René J.V. Bertin wrote:
>     --e please, as I'm still male last I checked :P
>     
>     No problem as far as I'm concerned to update blogger.cpp too. In fact it's surprising that this isn't necessary.
>     
>     NB: my name is on this RR because I suggested the patch on a bug tracker, the reporter then reported back that it solved the build issue, and Marko then submitted the patch to RB. Credit where credit is due - I'm just the brains on this one, not the author ;)
> 
> Marko Käning wrote:
>     Without brains no authorship. ;)
>     
>     I considered myself here only as the messenger! =)
> 
> René J.V. Bertin wrote:
>     I've prepared a new patch, but can apparently only upload it as an inline comment?
>     
>     Is there a way to set up this RR so that I too can at least upload attachments?
> 
> Sandro Knauß wrote:
>     Well you are not (marked) as the autor of this RR, so either you upload a new RR yourself or give the new patch to Marko, so he can update the RR.
> 
> René J.V. Bertin wrote:
>     That's not very efficient, the software could at least allow others to upload attachments ...
>     
>     There's a kde-mac group. Can "kde-mac" also act as a RR author so that (select) group members can share the credentials and truly collaborate on updating review requests?
> 
> Marko Käning wrote:
>     René, you were referring to an updated patch above. Now that the empowered kde-mac users are set up you could try to post it here! :)
> 
> Marko Käning wrote:
>     What is the status of this one? Has it made it into KF5's code?
> 
> Marko Käning wrote:
>     René, what about the status of this patch? Were you able to commit it in the meantime?
> 
> René J.V. Bertin wrote:
>     Well, in the meantime I migrated to KDE PIM `KDE/4.14` branch (@08e5d90). I forgot to update the official/mainstream MacPorts patches, and it turns out that the code built just fine on OS X 10.9 without the patch proposed here. That's with the latest Xcode available for 10.9 (= v6.2).
>     
>     To answer your question: the patch status is "should be double-checked by others (on OS X 10.9+) to see if it's really required still". Maybe the clang bug Daniel referred to above is no longer present in the most recent clang version for 10.9. But it doesn't appear impossible that I've built the code with a non-standard compiler option that doesn't trigger the bug.

This builds for me on 10.9.5 with xcode 6.1.1 just fine, i.e. the bug is gone.


- Marko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122940/#review77524
-----------------------------------------------------------


On March 14, 2015, 1:45 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122940/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 1:45 p.m.)
> 
> 
> Review request for KDEPIM, Laurent Montel and René J.V. Bertin.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The MacPorts' ticket [#47087](http://trac.macports.org/ticket/47087) describes the details and offers this patch.
> 
>  * Has this code already made it into KF5?
>  * And if so, which frameworks contains this code now? Does it still need fixing there?
> 
> Thanks, René, for supplying the patch.
> 
> 
> Diffs
> -----
> 
>   blogilo/src/blogger.h 9e9da5208d1f28d19c03c1e5d06f44dc3bafa3fe 
> 
> Diff: https://git.reviewboard.kde.org/r/122940/diff/
> 
> 
> Testing
> -------
> 
> Builds fine on MacPorts. Refer to above ticket.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/