[Kde-pim] Review Request 125577: Extend the purpose of GrantleeTheme library and refresh the KMail/Kontact "Introduction" pages theme

Wed Oct 14 13:13:57 BST 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125577/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 12:13 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDEPIM and Laurent Montel.

Changes
-------

Submitted with commit b9c428ce0417feaa6eb0d3d8c5737f143f55339e by Dan Vrátil to branch master.

Repository: kdepim

Description
-------

So, this tiny patch does two things (it can be split when committed, but for discussion I think it's better to have it as one):
  1) it repurposes GrantleeTheme to be able to not just manage Grantlee theme packs, but also to render them. I basically forked some of the logic from the Grantlee template management code I wrote for KCalUtils (once GrantleeTheme is split out of kdepim, I'll make KCalUtils use it). This is useful because the way we use Grantlee is very repetitive (Engine, Loader -> load plugins -> render), so wrapping that into GrantleeTheme::Theme looks like a good idea, it hides the ugliness of the theme/template path lookup.

  2) it creates new Grantlee templates for the "Introduction" pages for KMail and Kontact (Help -> Introduction), as well as the "Retrieving folder contents ..." page and similar info views shown in KMail. We do it using the extended GrantleeTheme functionality. See the attached screenshots - if this ain't superfancy, I don't know what is...:)

PS: Akregator has the same infopage too, but it's not using MessageViewer for obvious reasons, so the way there would be to copy the create Akregator's own Grantlee theme and make Akregator use GrantleeTheme as well. Let's do it once the underlaying stuff is in.

Diffs
-----

  grantleetheme/CMakeLists.txt 40286b6 
  grantleetheme/autotest/data/valid/header.html PRE-CREATION 
  grantleetheme/autotest/data/valid/header_expected.html PRE-CREATION 
  grantleetheme/autotest/data/valid/main.html PRE-CREATION 
  grantleetheme/autotest/grantleethemetest.h bb55bf4 
  grantleetheme/autotest/grantleethemetest.cpp fb6a4cf 
  grantleetheme/src/CMakeLists.txt fffaf15 
  grantleetheme/src/config-grantleetheme.h.cmake PRE-CREATION 
  grantleetheme/src/grantleeki18nlocalizer.cpp PRE-CREATION 
  grantleetheme/src/grantleeki18nlocalizer_p.h PRE-CREATION 
  grantleetheme/src/grantleetheme.h 995ee58 
  grantleetheme/src/grantleetheme.cpp ae0cafd 
  grantleetheme/src/grantleetheme_p.h PRE-CREATION 
  grantleetheme/src/grantleethememanager.h d08bcb7 
  grantleetheme/src/grantleethememanager.cpp 4e887a6 
  grantleetheme/src/plugin/CMakeLists.txt PRE-CREATION 
  grantleetheme/src/plugin/icon.h PRE-CREATION 
  grantleetheme/src/plugin/icon.cpp PRE-CREATION 
  grantleetheme/src/plugin/kdegrantleeplugin.h PRE-CREATION 
  grantleetheme/src/plugin/kdegrantleeplugin.cpp PRE-CREATION 
  kaddressbook/mainwidget.h 9c9946f 
  kaddressbook/mainwidget.cpp 734a3c3 
  kaddressbookgrantlee/src/widget/grantleecontactviewer.cpp 56c2a9f 
  kdepim.categories 40ff764 
  kmail/about/CMakeLists.txt c10672a 
  kmail/about/introduction_kmail.html PRE-CREATION 
  kmail/about/kmail.css 4cddf98 
  kmail/about/main.html 6d86a45 
  kmail/about/top-left-kmail.png f705363 
  kmail/kmreaderwin.h f1e0f40 
  kmail/kmreaderwin.cpp 4886b27 
  kontact/src/CMakeLists.txt ca52422 
  kontact/src/about/CMakeLists.txt 123fb3c 
  kontact/src/about/introduction_kontact.html PRE-CREATION 
  kontact/src/about/kontact.css 59de61d 
  kontact/src/about/loading_kontact.html PRE-CREATION 
  kontact/src/about/main.html 60845da 
  kontact/src/about/top-left-kontact.png 94d7248 
  kontact/src/mainwindow.h 7387cbc 
  kontact/src/mainwindow.cpp 8725b5e 
  messageviewer/CMakeLists.txt be8c217 
  messageviewer/src/CMakeLists.txt 799cab9 
  messageviewer/src/about/CMakeLists.txt PRE-CREATION 
  messageviewer/src/about/default/CMakeLists.txt PRE-CREATION 
  messageviewer/src/about/default/background.png PRE-CREATION 
  messageviewer/src/about/default/main.css PRE-CREATION 
  messageviewer/src/about/default/main.html PRE-CREATION 
  messageviewer/src/about/default/splash.theme PRE-CREATION 
  messageviewer/src/about/default/status.html PRE-CREATION 
  messageviewer/src/header/grantleeheaderstyleplugin/grantleeheaderstyleinterface.h 1fdf939 
  messageviewer/src/header/grantleeheaderstyleplugin/grantleeheaderstyleinterface.cpp 50325c4 
  messageviewer/src/viewer/mailwebview_webkit.cpp bccdc78 
  messageviewer/src/viewer/viewer.h 3382deb 
  messageviewer/src/viewer/viewer.cpp 42bb945 
  messageviewer/src/viewer/viewer_p.h 03e2b77 
  messageviewer/src/viewer/viewer_p.cpp a016eb6 

Diff: https://git.reviewboard.kde.org/r/125577/diff/

Testing
-------

Yes, works. The only problem seems to be that sometimes QtWebKit is ridiculously slow rendering the background wallpaper, so you can see it slowly render, as if you were downloading it via 56k modem - but I guess there's not much we can do about it.

File Attachments
----------------

KMail Introduction
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/09/6a6b83c8-aca5-4269-9e66-f79e1e1c10e7__kmail.png
KMail "busy" page
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/09/aef41331-c1a0-4778-b342-45f9e868d1bc__kmail3.png
Kontact Introduction
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/09/bb6c4cbb-97d3-42b1-b677-d2c8c10bd111__kontact.png

Thanks,

Daniel Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/