[Kde-pim] Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

[R.Harish Navnit]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125570/#review87193
-----------------------------------------------------------


Ping ?

- R.Harish  Navnit


On Oct. 12, 2015, 12:24 a.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125570/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 12:24 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kde-dev-scripts
> 
> 
> Description
> -------
> 
> A lot of KABC classes are deprecated in KF5. The porting script only replaces kabc occurences to kcontacts, but overlooks if the class being used still exists in kcontact or not. This leads to a lot of compile time #include<> errors. I feel this should and can be avoided by modifying the script. Was this overlooked on purpose or did we just miss it out ?
> 
> I've really no prior knowledge or experience of working with perl and I've tried to handle the above mentioned scenario, by manually checking for deprecated classnames and replacing them with a blank space or commenting them out.
> 
> 
> Diffs
> -----
> 
>   kf5/convert-kabc-to-kcontacts.pl 321fdf2c92745a3aece8e66085994458720f9dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/125570/diff/
> 
> 
> Testing
> -------
> 
> Ran the script on the kopete codebase which uses deprecated classes like addressbook, stdaddressbook, resource etc. 
> Works fine, but takes a bit of time to execute.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/