[Kde-pim] Review Request 125632: Bring back KRunner plugin for searching contacts

Volker Krause vkrause at kde.org
Wed Oct 14 17:45:57 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125632/#review86851
-----------------------------------------------------------


Looks good to me, but I have no experience with KRunner.


akonadi-search.categories (line 4)
<https://git.reviewboard.kde.org/r/125632/#comment59731>

    _a_konadi?


- Volker Krause


On Oct. 14, 2015, 11:16 a.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125632/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 11:16 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: akonadi-search
> 
> 
> Description
> -------
> 
> This brings back the Krunner plugin to search for contacts in addressbook by name and email and allows to send them email by just hitting enter.
> 
> The plugin also optinally searches in the autocompleter index, i.e. emails indexed from received/sent emails. This can be turned off optionally.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e48f521 
>   akonadi-search.categories d932d76 
>   runner/CMakeLists.txt PRE-CREATION 
>   runner/pimcontactsrunner.h PRE-CREATION 
>   runner/pimcontactsrunner.cpp PRE-CREATION 
>   runner/pimcontactsrunnerconfig.h PRE-CREATION 
>   runner/pimcontactsrunnerconfig.cpp PRE-CREATION 
>   runner/plasma-krunner-pimcontacts.desktop PRE-CREATION 
>   runner/plasma-krunner-pimcontacts_config.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125632/diff/
> 
> 
> Testing
> -------
> 
> Works here.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list