[Kde-pim] Review Request 123509: Fix no-op line in template parser
Laurent Montel
montel at kde.org
Fri Oct 2 20:38:00 BST 2015
> On sep. 14, 2015, 6:17 après-midi, Allen Winter wrote:
> > was this one every committed?
>
> Sergio Martins wrote:
> No. Laurent, good to go ?
Oh I commited long time ago but forgot to close it (long time ago it's 4.14 branch I think)
- Laurent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123509/#review85397
-----------------------------------------------------------
On avr. 26, 2015, 6:52 après-midi, Sergio Martins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123509/
> -----------------------------------------------------------
>
> (Updated avr. 26, 2015, 6:52 après-midi)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Fix no-op line, toHtmlEscaped() is const, it doesn't alter the object.
> Didn't do any testing, so I'm putting this in review board. I don't have a working setup today, but this seems like low hanging fruit.
>
>
> Diffs
> -----
>
> templateparser/templateparser.cpp 20e740a
>
> Diff: https://git.reviewboard.kde.org/r/123509/diff/
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sergio Martins
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list