[Kde-pim] Review Request 125747: Check calendar pointer before access it in writeFile() in kalarm resource

Xuetian Weng wengxt at gmail.com
Thu Oct 29 14:53:03 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125747/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 2:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM, Laurent Montel and Sergio Martins.


Changes
-------

Submitted with commit a528dcf98582da1c49163ff93209fd00090eac01 by Weng Xuetian to branch Applications/15.08.


Repository: kdepim-runtime


Description
-------

As a side-effect caused by 1612e91eb5540fc25e4fa4a7bfe28d3512439318, now kalarm resource would crash when stop or being created. 

Not quite sure if this is the correct fix, but ICalResourceBase seems did a lot of check on mCalendar, so I guess check calendar() in kalarma also makes sense?


Diffs
-----

  resources/kalarm/kalarm/kalarmresource.cpp f0d9a27 

Diff: https://git.reviewboard.kde.org/r/125747/diff/


Testing
-------

No crash on kalarm resource in the same situation.


Thanks,

Xuetian Weng

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list