[Kde-pim] Review Request 123625: Kolab patches: korganizer (new files) [1/2]

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123625/#review79937
-----------------------------------------------------------



korganizer/autotests/koeventpopupmenutest.cpp (line 266)
<https://git.reviewboard.kde.org/r/123625/#comment54786>

    it doesn't compile.
    Please make sure that all patch compile before to post them.



korganizer/noteeditdialog.cpp (line 59)
<https://git.reviewboard.kde.org/r/123625/#comment54784>

    Remove this line



korganizer/noteeditdialog.cpp (line 119)
<https://git.reviewboard.kde.org/r/123625/#comment54785>

    text().trimmed().isEmpty() && toPlainText().trimmed().isEmpty()...



korganizer/views/collectionview/autotests/modeltest.h (line 37)
<https://git.reviewboard.kde.org/r/123625/#comment54792>

    Q_NULLPTR



korganizer/views/collectionview/autotests/modeltest.cpp (line 522)
<https://git.reviewboard.kde.org/r/123625/#comment54793>

    ++ii



korganizer/views/collectionview/autotests/modeltest.cpp (line 626)
<https://git.reviewboard.kde.org/r/123625/#comment54794>

    ++ii



korganizer/views/collectionview/calendardelegate.cpp (line 244)
<https://git.reviewboard.kde.org/r/123625/#comment54787>

    ++i



korganizer/views/collectionview/controller.cpp (line 88)
<https://git.reviewboard.kde.org/r/123625/#comment54788>

    Fix i18n please.
    api is i18n("...%1...", QLatin1String("ddd"))...
    and i18nc is already a QString 
    => remove QString before



korganizer/views/collectionview/icons/CMakeLists.txt (line 12)
<https://git.reviewboard.kde.org/r/123625/#comment54795>

    ${KDE_INSTALL_ICONDIR}



korganizer/views/collectionview/quickview.cpp (line 62)
<https://git.reviewboard.kde.org/r/123625/#comment54789>

    Fix i18n api please.



korganizer/views/collectionview/reparentingmodel.cpp (line 71)
<https://git.reviewboard.kde.org/r/123625/#comment54790>

    ++it



korganizer/views/collectionview/reparentingmodel.cpp (line 355)
<https://git.reviewboard.kde.org/r/123625/#comment54791>

    no connect api here ?


- Laurent Montel


On mai 5, 2015, 8:02 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123625/
> -----------------------------------------------------------
> 
> (Updated mai 5, 2015, 8:02 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * Create Event/Note/Todo of of Event/Todo (noteeditdialog)
> * new collectionview (views/collectionview)
> * search for open/decliend Invitations (searchcollectionhelper)
> 
> 
> Diffs
> -----
> 
>   korganizer/CMakeLists.txt 1cc701b93d2ac735fbde2ba3ed13cbc917659a23 
>   korganizer/autotests/CMakeLists.txt c04d61afd0a1ad31fa6a2cebedb7d78880c61fe5 
>   korganizer/autotests/koeventpopupmenutest.h PRE-CREATION 
>   korganizer/autotests/koeventpopupmenutest.cpp PRE-CREATION 
>   korganizer/autotests/noteeditdialogtest.h PRE-CREATION 
>   korganizer/autotests/noteeditdialogtest.cpp PRE-CREATION 
>   korganizer/noteeditdialog.h PRE-CREATION 
>   korganizer/noteeditdialog.cpp PRE-CREATION 
>   korganizer/searchcollectionhelper.h PRE-CREATION 
>   korganizer/searchcollectionhelper.cpp PRE-CREATION 
>   korganizer/views/collectionview/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/autotests/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/autotests/modeltest.h PRE-CREATION 
>   korganizer/views/collectionview/autotests/modeltest.cpp PRE-CREATION 
>   korganizer/views/collectionview/autotests/reparentingmodeltest.cpp PRE-CREATION 
>   korganizer/views/collectionview/calendardelegate.h PRE-CREATION 
>   korganizer/views/collectionview/calendardelegate.cpp PRE-CREATION 
>   korganizer/views/collectionview/controller.h PRE-CREATION 
>   korganizer/views/collectionview/controller.cpp PRE-CREATION 
>   korganizer/views/collectionview/icons/128-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/16-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/22-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/256-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/32-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/48-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/64-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/icons/sc-apps-quickview.svgz PRE-CREATION 
>   korganizer/views/collectionview/quickview.h PRE-CREATION 
>   korganizer/views/collectionview/quickview.cpp PRE-CREATION 
>   korganizer/views/collectionview/quickview.ui PRE-CREATION 
>   korganizer/views/collectionview/reparentingmodel.h PRE-CREATION 
>   korganizer/views/collectionview/reparentingmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/