[Kde-pim] Review Request 123560: kolabchanges: messageviewer [2/4]

[Laurent Montel]

> On avr. 30, 2015, 11:12 matin, Laurent Montel wrote:
> > messageviewer/job/createtodojob.cpp, line 110
> > <https://git.reviewboard.kde.org/r/123560/diff/2/?file=365212#file365212line110>
> >
> >     We don't test error here ?
> >     We are for sure that job result is alway ok ?
> 
> Sandro Knauß wrote:
>     This was chagned by Aaron with the following message:
>     
>     commit 4a01a063f9ebfc27f238896df89bbfaac1e54b30
>     Author: Aaron Seigo <aseigo at kde.org>
>     Date:   Thu Oct 9 15:58:00 2014 +0200
>     
>         we don't really care about errors in the end
>         
>         relations can only be formed if the mail and the note are in the same
>         collection. so it is completely plausible for a relation to fail but
>         the note is created and stored in akonadi where requestsed.

So this slot is not necessary if you don't check it.
Remove it.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123560/#review79724
-----------------------------------------------------------


On avr. 30, 2015, 9:49 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123560/
> -----------------------------------------------------------
> 
> (Updated avr. 30, 2015, 9:49 matin)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create notes from email
> * show close instead of cancel
> 
> 
> Diffs
> -----
> 
>   messageviewer/job/createeventjob.h e543b8197bc2e7739ed69077e0c39338ae81f342 
>   messageviewer/job/createeventjob.cpp 4c8c182f6d2c7f27e564c55d8b6b69f007a04198 
>   messageviewer/job/createnotejob.h PRE-CREATION 
>   messageviewer/job/createnotejob.cpp PRE-CREATION 
>   messageviewer/job/createtodojob.h 921290f4c99b65b1e0351b3f05183ed47b8c00b4 
>   messageviewer/job/createtodojob.cpp f8947424b63cfa537cc089fa6a6a4b056097e2b5 
>   messageviewer/tests/viewertest_gui.cpp 1693fd768eacf71df4d8dfb97331af491ee84f56 
>   messageviewer/widgets/noteedit.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123560/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/