[Kde-pim] Review Request 123558: kolabchanges: messageviewer [4/4]

Laurent Montel montel at kde.org
Sun May 10 07:23:22 BST 2015



> On mai 8, 2015, 5:29 matin, Laurent Montel wrote:
> > messageviewer/CMakeLists.txt, line 108
> > <https://git.reviewboard.kde.org/r/123558/diff/2/?file=367405#file367405line108>
> >
> >     why it's in this patch ?
> >     I don't see new file here.
> 
> Sandro Knauß wrote:
>     The new files are in https://git.reviewboard.kde.org/r/123560, because all 4 review request will be one merge, they will become together.
>     
>     It was an unhappy split between the requests...

Ok I see.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123558/#review80072
-----------------------------------------------------------


On mai 7, 2015, 1:56 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123558/
> -----------------------------------------------------------
> 
> (Updated mai 7, 2015, 1:56 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create notes from email
> * show close instead of cancel
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 20ecca9414eff7a50133e1cdd221d098d40aa34b 
>   messageviewer/CMakeLists.txt 2b35645d3490e12f13d8779302871e1d385ccb50 
>   messageviewer/settings/messageviewer.kcfg.cmake 1b0d50163d48b6442b3386abd19f7a2c1c558462 
> 
> Diff: https://git.reviewboard.kde.org/r/123558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list