[Kde-pim] Review Request 123681: Fix build with Qt 5.5
Christian Mollekopf
chrigi_1 at fastmail.fm
Fri May 8 13:22:24 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123681/#review80085
-----------------------------------------------------------
Using something like:
std::transform(flags.begin(), flags.end(), flags.begin(), boost::bind(static_cast<void(QByteArray::*)() const>(&QByteArray::toLower), _1));
doesn't work?
If not you can go ahead from my side with what you did.
src/listjob.cpp (line 181)
<https://git.reviewboard.kde.org/r/123681/#comment54940>
Spaces around != I believe.
- Christian Mollekopf
On May 8, 2015, 12:02 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123681/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:02 p.m.)
>
>
> Review request for KDEPIM-Libraries, Christian Mollekopf and Laurent Montel.
>
>
> Repository: kimap
>
>
> Description
> -------
>
> Now QByteArray::toLower is overloaded. I didn't manage to tell bind what version to use.
> I spent some time (more than I'd care to admit, in fact) trying to work it out but didn't manage, so did this which works and it's probably even more readable.
>
>
> Diffs
> -----
>
> src/listjob.cpp eebd404
>
> Diff: https://git.reviewboard.kde.org/r/123681/diff/
>
>
> Testing
> -------
>
> Builds, tests still pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list