[Kde-pim] Review Request 123583: make all attachments accessible

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123583/#review79939
-----------------------------------------------------------

Ship it!


Seems good.
Ship it.

- Laurent Montel


On mai 1, 2015, 4:40 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123583/
> -----------------------------------------------------------
> 
> (Updated mai 1, 2015, 4:40 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> If we have encrypted and non encrypted attachment in the same mail, we
> also need to be able to access them. The persisentIndex was not aware of
> such nested attachments.
> 
> Because nodehelper creates the persistentIndex it should also have the
> reverse function contentFromIndex / fromHREF.
> 
> 
> Diffs
> -----
> 
>   messageviewer/viewer/viewer_p.cpp f93e130f90e58572227ed5b7519cf8e95844c7d5 
>   messageviewer/viewer/viewer_p.h d525b025c4207e2ade25deec01601603c4a6abda 
>   messageviewer/viewer/nodehelper.cpp 51d0bdd03923c710f883f673e43fefd1c50d0580 
>   messageviewer/viewer/nodehelper.h d29e474977777cfda0e91077db871fd2a00a2690 
>   messageviewer/tests/nodehelpertest.cpp PRE-CREATION 
>   messageviewer/tests/nodehelpertest.h PRE-CREATION 
>   messageviewer/tests/data/openpgp-encrypted-non-encrypted-attachment.mbox.html PRE-CREATION 
>   messageviewer/tests/data/openpgp-encrypted-non-encrypted-attachment.mbox PRE-CREATION 
>   messageviewer/tests/data/openpgp-encrypted-attachment.mbox.html PRE-CREATION 
>   messageviewer/tests/data/openpgp-encrypted-attachment.mbox PRE-CREATION 
>   messageviewer/tests/data/openpgp-encrypted-attachment-and-non-encrypted-attachment.mbox.html PRE-CREATION 
>   messageviewer/tests/data/openpgp-encrypted-attachment-and-non-encrypted-attachment.mbox PRE-CREATION 
>   messageviewer/tests/CMakeLists.txt f68a9231e7d90afb1d7a63d7f624912914cd26c9 
> 
> Diff: https://git.reviewboard.kde.org/r/123583/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/