[Kde-pim] Review Request 123541: kolab patches: accountwizard

Fri May 1 20:53:05 BST 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123541/#review79765
-----------------------------------------------------------


accountwizard/configfile.cpp (line 101)
<https://git.reviewboard.kde.org/r/123541/#comment54608>

    Q_EMIT


accountwizard/configfile.cpp (line 112)
<https://git.reviewboard.kde.org/r/123541/#comment54609>

    Q_EMIT


accountwizard/ispdb/autoconfigkolabfreebusy.h (line 46)
<https://git.reviewboard.kde.org/r/123541/#comment54620>

    coding style : port(80), ...


accountwizard/ispdb/autoconfigkolabfreebusy.h (line 57)
<https://git.reviewboard.kde.org/r/123541/#comment54621>

    Reorder variable. QString first


accountwizard/ispdb/autoconfigkolabldap.h (line 64)
<https://git.reviewboard.kde.org/r/123541/#comment54622>

    Reorder variable, QString first


accountwizard/ispdb/autoconfigkolabldap.cpp (line 36)
<https://git.reviewboard.kde.org/r/123541/#comment54623>

    QStringLiteral


accountwizard/ispdb/autoconfigkolabldap.cpp (line 68)
<https://git.reviewboard.kde.org/r/123541/#comment54624>

    Replace all QLatin1String by QStringLiteral


accountwizard/ispdb/autoconfigkolabmail.h (line 31)
<https://git.reviewboard.kde.org/r/123541/#comment54625>

    Q_DECL_OVERRIDE no ?


accountwizard/ispdb/autotests/autoconfigkolabfreebusy.cpp (line 55)
<https://git.reviewboard.kde.org/r/123541/#comment54629>

    new connect api ?


accountwizard/ispdb/autotests/autoconfigkolabldaptest.cpp (line 55)
<https://git.reviewboard.kde.org/r/123541/#comment54630>

    new connect api


accountwizard/ispdb/autotests/autoconfigkolabmailtest.cpp (line 32)
<https://git.reviewboard.kde.org/r/123541/#comment54631>

    Q_DECL_OVERRIDE ? same for other virtual method


accountwizard/ispdb/ispdb.cpp (line 32)
<https://git.reviewboard.kde.org/r/123541/#comment54626>

    coding style QObject(...),


accountwizard/ispdb/ispdb.cpp (line 63)
<https://git.reviewboard.kde.org/r/123541/#comment54627>

    QStringLiteral


accountwizard/ispdb/ispdb.cpp (line 98)
<https://git.reviewboard.kde.org/r/123541/#comment54628>

    Replace all QLAtin1String to QStringLiteral


accountwizard/ldap.cpp (line 60)
<https://git.reviewboard.kde.org/r/123541/#comment54610>

    Q_EMIT


accountwizard/ldap.cpp (line 147)
<https://git.reviewboard.kde.org/r/123541/#comment54611>

    const here


accountwizard/ldap.cpp (line 156)
<https://git.reviewboard.kde.org/r/123541/#comment54612>

    QString() directly no ?


accountwizard/ldap.cpp (line 197)
<https://git.reviewboard.kde.org/r/123541/#comment54613>

    Q_EMIT


accountwizard/ldap.cpp (line 204)
<https://git.reviewboard.kde.org/r/123541/#comment54614>

    Q_EMIT


accountwizard/page.cpp (line 52)
<https://git.reviewboard.kde.org/r/123541/#comment54615>

    KAssistandDialog *Page::...


accountwizard/resource.cpp (line 65)
<https://git.reviewboard.kde.org/r/123541/#comment54616>

    coding style:
    m_typeIdentifer(type),


accountwizard/setupautoconfigkolabfreebusy.cpp (line 87)
<https://git.reviewboard.kde.org/r/123541/#comment54617>

    Q_EMIT
    convert all emit to Q_EMIT


accountwizard/setupmanager.cpp (line 249)
<https://git.reviewboard.kde.org/r/123541/#comment54618>

    QStringLiteral


accountwizard/transport.cpp (line 80)
<https://git.reviewboard.kde.org/r/123541/#comment54619>

    coding style m_auth(....),


- Laurent Montel


On mai 1, 2015, 4:54 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123541/
> -----------------------------------------------------------
> 
> (Updated mai 1, 2015, 4:54 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I know it looks quite big, but most of the patch are the new files for autoconfig kolab and their tests.
> 
> * Accountwizard: Add Editmode for different setupobjects
>     
>     * for configfile (freebusy)
>     * for transport (smtp)
>     * for imap
>     * for ldap
> 
> * Add autoconfiguration for kolab
> * Added destroy option for ldap object.
> * Add submission protocoll to servertest
> 
> 
> Diffs
> -----
> 
>   accountwizard/CMakeLists.txt 79b089984e1f2c807bac85a94650e830ed74108f 
>   accountwizard/autotests/CMakeLists.txt PRE-CREATION 
>   accountwizard/autotests/data/ldap.cfg PRE-CREATION 
>   accountwizard/autotests/ldaptest.cpp PRE-CREATION 
>   accountwizard/configfile.h c650b45c5ec852201e64c9d372600364e49429bd 
>   accountwizard/configfile.cpp ddce5dc4770524a946713dfc517e787aa578bae8 
>   accountwizard/ispdb/CMakeLists.txt 8acb996506746e0cd49c05aa2a39ec56b23e73a7 
>   accountwizard/ispdb/autoconfigkolabfreebusy.h PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabfreebusy.cpp PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabldap.h PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabldap.cpp PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabmail.h PRE-CREATION 
>   accountwizard/ispdb/autoconfigkolabmail.cpp PRE-CREATION 
>   accountwizard/ispdb/autotests/CMakeLists.txt PRE-CREATION 
>   accountwizard/ispdb/autotests/autoconfigkolabfreebusy.cpp PRE-CREATION 
>   accountwizard/ispdb/autotests/autoconfigkolabldaptest.cpp PRE-CREATION 
>   accountwizard/ispdb/autotests/autoconfigkolabmailtest.cpp PRE-CREATION 
>   accountwizard/ispdb/autotests/data/autoconfig.xml PRE-CREATION 
>   accountwizard/ispdb/autotests/data/freebusy.xml PRE-CREATION 
>   accountwizard/ispdb/autotests/data/ldap.xml PRE-CREATION 
>   accountwizard/ispdb/autotests/errorserver.py PRE-CREATION 
>   accountwizard/ispdb/autotests/ispdbtest.cpp PRE-CREATION 
>   accountwizard/ispdb/ispdb.h dc5aea8d5ec49952c6da7c05ac0f278f9a411f80 
>   accountwizard/ispdb/ispdb.cpp 724adfa6d0f50a2c50b54cbdd85f70a51e209b65 
>   accountwizard/ldap.h ee0482e5d70cc5489d0aa7095ff3ec924e7f703a 
>   accountwizard/ldap.cpp 6236c5b50d84095624874b4bfe67190e57b0c3e1 
>   accountwizard/page.h c52d5f6d93675c59e4040bb8b64b68e8e36a436c 
>   accountwizard/page.cpp d8cc5d102dbad880d13eff514b0837a9b67eb31b 
>   accountwizard/resource.h c1ed4cc0ccd6c7043cb51a96492f93ef268c02f3 
>   accountwizard/resource.cpp 5d6b062294184459ebf3fedb23c1753076aa3508 
>   accountwizard/servertest.cpp 71c77a19fb45a8dea802db2fdf72335c7cc698ab 
>   accountwizard/setupautoconfigkolabfreebusy.h PRE-CREATION 
>   accountwizard/setupautoconfigkolabfreebusy.cpp PRE-CREATION 
>   accountwizard/setupautoconfigkolabldap.h PRE-CREATION 
>   accountwizard/setupautoconfigkolabldap.cpp PRE-CREATION 
>   accountwizard/setupautoconfigkolabmail.h PRE-CREATION 
>   accountwizard/setupautoconfigkolabmail.cpp PRE-CREATION 
>   accountwizard/setupispdb.h PRE-CREATION 
>   accountwizard/setupispdb.cpp PRE-CREATION 
>   accountwizard/setupmanager.h e4f425c5996ea6e7b90da35071fcb40ebc747a2f 
>   accountwizard/setupmanager.cpp 7a67e044c43eabe8b0a11c5731486271cfadf7a9 
>   accountwizard/transport.h c2acc69be5ce34b8c7a2c3344811b45cf6454f1c 
>   accountwizard/transport.cpp cce4a10adb47b8bf6a04532bc0ad52cbc73106f5 
> 
> Diff: https://git.reviewboard.kde.org/r/123541/diff/
> 
> 
> Testing
> -------
> 
> make compile & run tests
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/