[Kde-pim] Review Request 123624: Kolab patches: korganizer (changed files) [2/2]

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123624/#review79841
-----------------------------------------------------------



korganizer/akonadicollectionview.cpp (line 109)
<https://git.reviewboard.kde.org/r/123624/#comment54695>

    ++i



korganizer/akonadicollectionview.cpp (line 267)
<https://git.reviewboard.kde.org/r/123624/#comment54696>

    Q_NULLPTR



korganizer/akonadicollectionview.cpp (line 356)
<https://git.reviewboard.kde.org/r/123624/#comment54697>

    Q_NULLPTR where possible



korganizer/akonadicollectionview.cpp (line 363)
<https://git.reviewboard.kde.org/r/123624/#comment54698>

    Q_DECL_OVERRIDE where possible



korganizer/akonadicollectionview.cpp (line 414)
<https://git.reviewboard.kde.org/r/123624/#comment54699>

    ++i ...



korganizer/akonadicollectionview.cpp (line 1084)
<https://git.reviewboard.kde.org/r/123624/#comment54700>

    qCWarning(...)



korganizer/calendarview.cpp (line 109)
<https://git.reviewboard.kde.org/r/123624/#comment54701>

    coding style.



korganizer/koeventpopupmenu.cpp (line 60)
<https://git.reviewboard.kde.org/r/123624/#comment54702>

    move QAction *action; whare you use it first



korganizer/koeventpopupmenu.cpp (line 92)
<https://git.reviewboard.kde.org/r/123624/#comment54703>

    QStringLiteral as usual...



korganizer/koeventpopupmenu.cpp (line 351)
<https://git.reviewboard.kde.org/r/123624/#comment54704>

    qCDebug(...)



korganizer/koeventpopupmenu.cpp (line 378)
<https://git.reviewboard.kde.org/r/123624/#comment54705>

    QStringLiteral


- Laurent Montel


On mai 4, 2015, 11:59 matin, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123624/
> -----------------------------------------------------------
> 
> (Updated mai 4, 2015, 11:59 matin)
> 
> 
> Review request for KDEPIM, Christian Mollekopf and Sergio Luis Martins.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * Create Event/Note/Todo of of Event/Todo (noteeditdialog, koeventpopupmenu, views/todoview)
> * new collectionview (views/collectionview, akonadicollectionview)
> * search for open/decliend Invitations (searchcollectionhelper, calendarview)
> 
> 
> Diffs
> -----
> 
>   korganizer/akonadicollectionview.h 604b047a9b7d150018743422e51ffdd3d93895c6 
>   korganizer/akonadicollectionview.cpp 1a5631c0e795ca216bcd2964846b27a85c50eed7 
>   korganizer/calendarview.h 210f2e2994eaafcd769b9aa4b5e73540202cc06e 
>   korganizer/calendarview.cpp d3de5be90783cf5cfa9ff24f80b086ed6de07ab5 
>   korganizer/koeventpopupmenu.h f76ad2b4537a159f20093da004bfc1341b7d72d3 
>   korganizer/koeventpopupmenu.cpp 572078ec44d0bdf1886c1fd70af8208c628dd219 
>   korganizer/kohelper.h 66c4bd2c560f3db8fd22a46e2a9ee4a4a37a30f3 
>   korganizer/kohelper.cpp e1fe20332d9904a4098611a4098827c6937a9075 
>   korganizer/views/todoview/kotodoview.cpp 6f5200948dc35d098a5a00ea590f7b1a9d1ca3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/123624/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/