[Kde-pim] Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.
Michael Palimaka
kensington at gentoo.org
Mon May 11 17:55:41 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123724/
-----------------------------------------------------------
Review request for KDE Frameworks and KDEPIM.
Repository: kpeople
Description
-------
Hardcoding files like this seems like a bad idea.
Diffs
-----
autotests/persondatatests.h 30eeeb5cd647c713f1b438543a54516ced9f3ede
autotests/persondatatests.cpp 73098d3717509ad80761bbd02000b4ce5060bbb2
autotests/personsmodeltest.h 5b8879521f334459c4f73c2708b3368c543e40a3
autotests/personsmodeltest.cpp b19d1baf8a2c2e617d4b6128df29fbab3b8e61a7
Diff: https://git.reviewboard.kde.org/r/123724/diff/
Testing
-------
Tests still pass.
Thanks,
Michael Palimaka
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list