[Kde-pim] Review Request 123625: Kolab patches: korganizer (new files) [1/2]

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123625/#review79840
-----------------------------------------------------------



korganizer/autotests/koeventpopupmenutest.h (line 35)
<https://git.reviewboard.kde.org/r/123625/#comment54684>

    Q_SLOTS



korganizer/autotests/koeventpopupmenutest.cpp (line 31)
<https://git.reviewboard.kde.org/r/123625/#comment54685>

    prot to qtest



korganizer/autotests/noteeditdialogtest.h (line 29)
<https://git.reviewboard.kde.org/r/123625/#comment54686>

    Q_SLOTS:



korganizer/autotests/noteeditdialogtest.cpp (line 28)
<https://git.reviewboard.kde.org/r/123625/#comment54687>

    port to qtest



korganizer/searchcollectionhelper.h (line 44)
<https://git.reviewboard.kde.org/r/123625/#comment54681>

    explicit



korganizer/searchcollectionhelper.h (line 56)
<https://git.reviewboard.kde.org/r/123625/#comment54682>

    const QString & name



korganizer/searchcollectionhelper.cpp (line 115)
<https://git.reviewboard.kde.org/r/123625/#comment54683>

    QStringLiteral where necessary



korganizer/views/collectionview/calendardelegate.h (line 29)
<https://git.reviewboard.kde.org/r/123625/#comment54688>

    explicit



korganizer/views/collectionview/calendardelegate.h (line 32)
<https://git.reviewboard.kde.org/r/123625/#comment54689>

    Q_DECL_OVERRIDE where necessary



korganizer/views/collectionview/controller.cpp (line 31)
<https://git.reviewboard.kde.org/r/123625/#comment54690>

    necessary ?



korganizer/views/collectionview/controller.cpp (line 299)
<https://git.reviewboard.kde.org/r/123625/#comment54691>

    Q_EMIT where necessary



korganizer/views/collectionview/icons/CMakeLists.txt (line 1)
<https://git.reviewboard.kde.org/r/123625/#comment54694>

    Port to kf5 macro
    
    Rename icons as new kf5 format
    => remove hi*
    => add THEME hicolor in macro.
    See other "install icons"



korganizer/views/collectionview/reparentingmodel.h (line 49)
<https://git.reviewboard.kde.org/r/123625/#comment54692>

    Q_DECL_OVERRIDE where necessary



korganizer/views/collectionview/reparentingmodel.cpp (line 305)
<https://git.reviewboard.kde.org/r/123625/#comment54693>

    ++i where necessary


- Laurent Montel


On mai 4, 2015, midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123625/
> -----------------------------------------------------------
> 
> (Updated mai 4, 2015, midi)
> 
> 
> Review request for KDEPIM, Christian Mollekopf and Sergio Luis Martins.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * Create Event/Note/Todo of of Event/Todo (noteeditdialog)
> * new collectionview (views/collectionview)
> * search for open/decliend Invitations (searchcollectionhelper)
> 
> 
> Diffs
> -----
> 
>   korganizer/searchcollectionhelper.h PRE-CREATION 
>   korganizer/noteeditdialog.h PRE-CREATION 
>   korganizer/autotests/noteeditdialogtest.h PRE-CREATION 
>   korganizer/autotests/koeventpopupmenutest.h PRE-CREATION 
>   korganizer/autotests/CMakeLists.txt c04d61afd0a1ad31fa6a2cebedb7d78880c61fe5 
>   korganizer/noteeditdialog.cpp PRE-CREATION 
>   korganizer/autotests/noteeditdialogtest.cpp PRE-CREATION 
>   korganizer/autotests/koeventpopupmenutest.cpp PRE-CREATION 
>   korganizer/CMakeLists.txt 1cc701b93d2ac735fbde2ba3ed13cbc917659a23 
>   korganizer/searchcollectionhelper.cpp PRE-CREATION 
>   korganizer/views/collectionview/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/autotests/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/autotests/modeltest.h PRE-CREATION 
>   korganizer/views/collectionview/autotests/modeltest.cpp PRE-CREATION 
>   korganizer/views/collectionview/autotests/reparentingmodeltest.cpp PRE-CREATION 
>   korganizer/views/collectionview/calendardelegate.h PRE-CREATION 
>   korganizer/views/collectionview/calendardelegate.cpp PRE-CREATION 
>   korganizer/views/collectionview/controller.h PRE-CREATION 
>   korganizer/views/collectionview/controller.cpp PRE-CREATION 
>   korganizer/views/collectionview/icons/CMakeLists.txt PRE-CREATION 
>   korganizer/views/collectionview/icons/hi128-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hi16-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hi22-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hi256-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hi32-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hi48-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hi64-apps-quickview.png PRE-CREATION 
>   korganizer/views/collectionview/icons/hisc-apps-quickview.svgz PRE-CREATION 
>   korganizer/views/collectionview/quickview.h PRE-CREATION 
>   korganizer/views/collectionview/quickview.cpp PRE-CREATION 
>   korganizer/views/collectionview/quickview.ui PRE-CREATION 
>   korganizer/views/collectionview/reparentingmodel.h PRE-CREATION 
>   korganizer/views/collectionview/reparentingmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123625/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/