[Kde-pim] Review Request 123641: VacationDialog: Add subject

[Sandro Knauß]

> On Mai 6, 2015, 4:38 vorm., Laurent Montel wrote:
> > libksieve/ksieveui/vacation/vacationscriptextractor.cpp, line 70
> > <https://git.reviewboard.kde.org/r/123641/diff/2/?file=366490#file366490line70>
> >
> >     Is it possible to create a autotest to validate that subject is correctly extracted ?

there are still outstanding patches for libksieve, where i also added tests around vacationscript. But the tests are not compatible to the version now, because I first restructed the VacationUtils:
struct Vacation;
Vacation parseScript(const QString &script);

with the test:
    VacationUtils::Vacation vacation = VacationUtils::parseScript(script);
    QCOMPARE(vacation.subject, QLatin1String("XXX"));

After the merge I can focus aain on writing new code and bring this branch ready for upstream.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123641/#review79936
-----------------------------------------------------------


On Mai 5, 2015, 3:31 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123641/
> -----------------------------------------------------------
> 
> (Updated Mai 5, 2015, 3:31 nachm.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> You often wants to set also the subject of the vacation messages.
> 
> 
> Diffs
> -----
> 
>   libksieve/ksieveui/vacation/vacationutils.cpp 85a3e2cc02530e0ec58789dd79c13038f23126ef 
>   libksieve/ksieveui/vacation/vacationutils.h d46ab48e30d36080f142611008fcfe5b6b3c302e 
>   libksieve/ksieveui/vacation/vacationscriptextractor.cpp 8d87f8d6b7fe31e3eda2b0995eedb010636d621d 
>   libksieve/ksieveui/vacation/vacationscriptextractor.h d5e6b10414d6aaf1b4d36e068bd3405dda8d756d 
>   libksieve/ksieveui/vacation/vacationpagewidget.cpp 1ef1f1f17b14fffb28b09ccd079e6ee45c1b03bb 
>   libksieve/ksieveui/vacation/vacationeditwidget.cpp 97062b37183945dfcb873f42448814c64ea50109 
>   libksieve/ksieveui/vacation/vacationeditwidget.h d076fceeeed40355501e584a5794846e8e5cd713 
>   libksieve/ksieveui/vacation/vacationdialog.cpp 8771ac4ac33a0ab47fd899377a1e1b354640da97 
>   libksieve/ksieveui/vacation/vacationdialog.h 6f8730ca854e6d397d2df9ec4372c79dd107388c 
>   libksieve/ksieveui/vacation/vacationcheckjob.cpp d22261efc85ed0a305117590613923cbb0f8ead5 
>   libksieve/ksieveui/vacation/vacation.cpp 886d0430da208d1b4f8d03d17420593c76b8b7c8 
> 
> Diff: https://git.reviewboard.kde.org/r/123641/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/