[Kde-pim] Review Request 123581: Use SHARE_INSTALL_PREFIX to install akonadi's desktop files

Laurent Montel montel at kde.org
Fri May 1 14:56:49 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123581/#review79760
-----------------------------------------------------------

Ship it!


Seems good for me.
Ship it in 4.14 I will merge after in master.
Thanks

- Laurent Montel


On mai 1, 2015, 12:30 après-midi, Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123581/
> -----------------------------------------------------------
> 
> (Updated mai 1, 2015, 12:30 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This is helpful on a multiarch layout where the prefix is /usr/${host}
> but arch-independent files should still be installed to /usr/share.
> 
> 
> Diffs
> -----
> 
>   agents/CMakeLists.txt 226edbd68c375e7d8271e8c8c564ae452e3e906e 
>   agents/invitations/CMakeLists.txt 62b044a223c15fb70aaba4bd3416eaf81b3e093d 
>   agents/maildispatcher/CMakeLists.txt 069515004c209c639a69a7e8a3f9d10ad6fe1ecb 
>   agents/migration/CMakeLists.txt 38e7bb03aec004b53d9cb621f856fd3bdb6e0e1b 
>   agents/newmailnotifier/CMakeLists.txt 3c114ad7aa80b7ec1470a890585699801f100d11 
>   resources/akonotes/CMakeLists.txt 2fdeafe8a6411ab1e74ef9979dc8d09fc69bb1e7 
>   resources/birthdays/CMakeLists.txt 29538d33e437049c232a84e2a702310628a81a99 
>   resources/contacts/CMakeLists.txt f1733dbb422d69a99ddfdee98690b32c0296f701 
>   resources/dav/resource/CMakeLists.txt 8b50d9336ceefee3959e82ab2493fc40b2e0910a 
>   resources/facebook/CMakeLists.txt 0623ee7ef301c801f2b9fbbc3751d72aefe7e229 
>   resources/gmail/CMakeLists.txt 6060e45473ad27692b144fed0f92d09a8e82d2ac 
>   resources/google/calendar/CMakeLists.txt ac5e7d1774467247335b3a8d910e2888e615ca7c 
>   resources/google/contacts/CMakeLists.txt 14be1996ec5bc25432da7705071ff6a5ed7eadd1 
>   resources/ical/CMakeLists.txt e457d983362d954440fc7327790018976785b530 
>   resources/ical/notes/CMakeLists.txt 8a9536f2ddd1569c6a14656b331269c5baef95d1 
>   resources/icaldir/CMakeLists.txt 3ca6c5e44a02027791341ee837df88e276231d90 
>   resources/imap/CMakeLists.txt 3949c2e959803eb4f93fbc455e3c811d2e554e10 
>   resources/kabc/CMakeLists.txt 4b91ba57bd390c22ab22b9440723b0e0a602ea15 
>   resources/kalarm/kalarm/CMakeLists.txt e38a620e5ed8a4da3b61d5c69c7f1c503ebc63b2 
>   resources/kalarm/kalarmdir/CMakeLists.txt 2a64575e5eee7a6b50825b45bb0128d7eb7fefaf 
>   resources/kcal/CMakeLists.txt 1c55c7bfa925f8a52afa3779d7e0c29d9a03c2f2 
>   resources/kdeaccounts/CMakeLists.txt d8569fefb7c4943fe6df6ad3f99ba40130f100b6 
>   resources/kolab/CMakeLists.txt 0e8e237a6b9f3d1f77154a0625981ade770a23da 
>   resources/kolabproxy/CMakeLists.txt 9827ade7f1d1c8661f24f7ecb1689c7c17987f27 
>   resources/localbookmarks/CMakeLists.txt 92f8259ede57c965f7041f4192c17a8e2a0c42dd 
>   resources/maildir/CMakeLists.txt 7df8c33c0a1c074130fccd7ca6d8f8390da95a2b 
>   resources/mailtransport_dummy/CMakeLists.txt c2dcf9ef5833e9f771db796869741c0bce580f35 
>   resources/mbox/CMakeLists.txt 618851d0a73ea32f6570261b65627d8ff807c71a 
>   resources/mixedmaildir/CMakeLists.txt 9445c017d1c004e72384e7722c494b4055a0048b 
>   resources/nntp/CMakeLists.txt 2ae613123eaebb7d614c9e98d607dc0f68457b4a 
>   resources/openxchange/CMakeLists.txt 62be1af728b121711d040c32f9ab814a07cdd9d6 
>   resources/pop3/CMakeLists.txt d7bd1a8c583109dc9b2b6bede309038d0aa6827a 
>   resources/vcard/CMakeLists.txt 7b1ec091688397950f57d3fe50191b8871704ef9 
>   resources/vcarddir/CMakeLists.txt 517080e1db3f7237f828067982b26a343fb67c3f 
> 
> Diff: https://git.reviewboard.kde.org/r/123581/diff/
> 
> 
> Testing
> -------
> 
> cmake ... -DCMAKE_INSTALL_PREFIX:PATH=/usr/x86_64-pc-linux-gnu -DSHARE_INSTALL_DIR=/usr/share .. && make && make install installed into the desired locations.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list