[Kde-pim] Review Request 123708: Use QNetworkConfigurationManager instead of Solid::Networking

[Armin K.]

> On May 10, 2015, 6:15 a.m., Laurent Montel wrote:
> > is it work ?
> > I am sure that it compiles but is it work ?

How do I test the codepath? Code is similar to the one in 

pimcommon/shorturl/shorturlwidget.cpp

but instead of dynamic allocation I used a temporary object as it was in the previous case with Solid::Networking. That can be easily changed.


- Armin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123708/#review80143
-----------------------------------------------------------


On May 9, 2015, 6:40 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123708/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 6:40 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Solid::Networking is deprecated
> 
> 
> Diffs
> -----
> 
>   libkdepim/addressline/addresslineedit/addresseelineedit_p.cpp 3d58dc9 
> 
> Diff: https://git.reviewboard.kde.org/r/123708/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/