[Kde-pim] Review Request 123558: kolabchanges: messageviewer [4/4]

[Laurent Montel]

> On mai 10, 2015, 6:24 matin, Laurent Montel wrote:
> > kmail/kmmainwidget.cpp, line 2774
> > <https://git.reviewboard.kde.org/r/123558/diff/2/?file=367404#file367404line2774>
> >
> >     I see "msMgView->createNoteActiin" in kmmainwidget.cpp but no in kmreadermainwin.cpp menu. Why ?
> 
> Sandro Knauß wrote:
>     also a problem of the spliting the review requests. see https://git.reviewboard.kde.org/r/123574 for the diff in kmreaderwin.

Ok I understand.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123558/#review80145
-----------------------------------------------------------


On mai 7, 2015, 1:56 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123558/
> -----------------------------------------------------------
> 
> (Updated mai 7, 2015, 1:56 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * create notes from email
> * show close instead of cancel
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 20ecca9414eff7a50133e1cdd221d098d40aa34b 
>   messageviewer/CMakeLists.txt 2b35645d3490e12f13d8779302871e1d385ccb50 
>   messageviewer/settings/messageviewer.kcfg.cmake 1b0d50163d48b6442b3386abd19f7a2c1c558462 
> 
> Diff: https://git.reviewboard.kde.org/r/123558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/